Merge pull request #30 from UrbanCompass/replay-fixes

Dont queue up done or error events
UrbanCompass · Dec 13, 2016 · fe9e323 · fe9e323
2 parents 2144a53 + 1917362
commit fe9e323
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Snail/Replay.swift b/Snail/Replay.swift
@@ -20,8 +20,10 @@ public class Replay<T>: Observable<T> {
     }
 
     public override func on(_ event: Event<E>) {
-        events.append(event)
-        events = Array(events.suffix(threshold))
+        if case .next(_) = event {
+            events.append(event)
+            events = Array(events.suffix(threshold))
+        }
         super.on(event)
     }
 

diff --git a/SnailTests/ReplayTests.swift b/SnailTests/ReplayTests.swift
@@ -33,6 +33,7 @@ class ReplayTests: XCTestCase {
         var strings: [String] = []
         subject?.on(.next("1"))
         subject?.on(.next("2"))
+        subject?.on(.done)
         subject?
             .subscribe(onNext: { string in strings.append(string) })
         XCTAssert(strings[0] == "1")