Resolved issue caused from bad merge #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewnitschke
commented
Apr 7, 2024
Comment on lines
-7
to
-8
| ; TODO: add method/call_expression to grammar and | ||
| ; distinguish method call from variable access |
There was a problem hiding this comment.
This was resolved in #65, just cleaning up the comment accordingly
matthewnitschke
commented
Apr 7, 2024
Comment on lines
-102
to
-105
| (enum_declaration | ||
| name: (identifier) @type) | ||
| (enum_constant | ||
| name: (identifier) @method) |
There was a problem hiding this comment.
These were duplicated, actual definition is lower: https://github.com/UserNobody14/tree-sitter-dart/pull/68/files#diff-d485a982e458ef8da2cc203585065b7542665cb80b78d230b1e8f77ea25825d4L117
There was a problem hiding this comment.
Thanks didn't notice the move
TimWhiting
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 Previous PRs were merged in parallel, causing a bad merge and failed CI
Enum highlighting is now handled in its own section, and constants are typed as
identifier.constantThis PR fixes what was added here