Enforces UTF-8 decoding in WebResponse #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinHttpRequest uses the users current code page (CP_ACP) to decode the response body, which on Windows is bound to fail for virtually all web services. This commit assumes the response is in UTF-8, but to be correct it should be attempted to determine the encoding from the Content-Type header followed by a fall-back to UTF-8. Also, the caller should have a way of overriding the encoding. Also, maybe something along the lines of chardet could be attempted.
|
Very cool! I’ve been looking for help on the UTF-8 issues and this is perfect. I’ll dive in and review this shortly |
|
Ha, just realized that in #276 it is mentioned that UTF-8 support is a problem on Mac, which my "hack" certainly will run into due to the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinHttpRequest uses the users current code page (CP_ACP) to decode the response body,
which on Windows is bound to fail for virtually all web services. This commit assumes the
response is in UTF-8, but to be correct it should be attempted to determine the encoding
from the Content-Type header followed by a fall-back to UTF-8. Also, the caller should have
a way of overriding the encoding. Also, maybe something along the lines of chardet could
be attempted.