Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve autoplay and clear some initialization variables #66

Merged
merged 26 commits into from
Oct 6, 2024
Merged

Improve autoplay and clear some initialization variables #66

merged 26 commits into from
Oct 6, 2024

Conversation

VDuchauffour
Copy link
Owner

@VDuchauffour VDuchauffour commented Sep 30, 2024 •
edited
Loading

What does this PR do?

This PR cleans the initialization variables in the c++ codebase.
Inspired by the following commits from RFC DOC:

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you run pre-commit hooks with pre-commit run -a command?

@github-actions github-actions bot added the chore Clean the codebase label Sep 30, 2024
@VDuchauffour VDuchauffour changed the title Chore/riseandfall Clear the initialization variables at game startup Oct 1, 2024
@VDuchauffour VDuchauffour changed the title Clear the initialization variables at game startup Improve autoplay and clear some initialization variables Oct 6, 2024
@VDuchauffour VDuchauffour merged commit a8564cd into main Oct 6, 2024
1 check passed
@VDuchauffour VDuchauffour deleted the chore/riseandfall branch October 6, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Clean the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VDuchauffour