Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScopeReducerExplorer #35

Merged
merged 9 commits into from
May 28, 2024
Merged

Add ScopeReducerExplorer #35

merged 9 commits into from
May 28, 2024

Conversation

viguardieiro
Copy link
Collaborator

No description provided.

@viguardieiro viguardieiro requested a review from roquelopez May 22, 2024 20:32
@roquelopez roquelopez force-pushed the add_scope_explorer branch from 63ff1ed to e53df3a Compare May 23, 2024 15:47
@roquelopez
Copy link
Collaborator

@viguardieiro I made some changes to include the explorer as part of the API. Feel free to merge it, thanks!

requirements.txt Outdated
@@ -8,3 +8,9 @@ scikit-learn
tabulate
flair
requests
scipy==1.10.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pin the exact version of all of these libraries? Couldn't we just specify the minimum and/or maximum versions that work with our code? I'm afraid that pinning very common libraries like scipy and matplotlib will cause conflicts with other libraries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PR #37, I was able to fix the errors by using just:

scipy<1.13
matplotlib<3.9

The root cause of the errors is in the packages PolyFuzz and gensim, which are transitive dependencies.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree, it's better to have flexible versions. I relaxed the versions of the other dependencies.

@EduardoPena
Copy link
Collaborator

@viguardieiro I made some changes to include the explorer as part of the API. Feel free to merge it, thanks!

The API import in the example was still referring to the old module, I added a small fix for that.

@roquelopez roquelopez force-pushed the add_scope_explorer branch from 55cb90d to c2e898a Compare May 28, 2024 14:45
@roquelopez roquelopez merged commit 47708c0 into devel May 28, 2024
8 checks passed
@roquelopez roquelopez deleted the add_scope_explorer branch May 28, 2024 15:08
aecio pushed a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants