-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ScopeReducerExplorer #35
Conversation
63ff1ed
to
e53df3a
Compare
@viguardieiro I made some changes to include the explorer as part of the API. Feel free to merge it, thanks! |
requirements.txt
Outdated
@@ -8,3 +8,9 @@ scikit-learn | |||
tabulate | |||
flair | |||
requests | |||
scipy==1.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to pin the exact version of all of these libraries? Couldn't we just specify the minimum and/or maximum versions that work with our code? I'm afraid that pinning very common libraries like scipy
and matplotlib
will cause conflicts with other libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR #37, I was able to fix the errors by using just:
scipy<1.13
matplotlib<3.9
The root cause of the errors is in the packages PolyFuzz and gensim, which are transitive dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, it's better to have flexible versions. I relaxed the versions of the other dependencies.
The API import in the example was still referring to the old module, I added a small fix for that. |
55cb90d
to
c2e898a
Compare
No description provided.