feat: Support for top-k value matches #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
roquelopez
force-pushed
the
top_value_matches
branch
from
eff84d8 to
453a436
Compare
roquelopez
changed the title
roquelopez
force-pushed
the
top_value_matches
branch
from
930b65f to
e60f14c
Compare
roquelopez
force-pushed
the
top_value_matches
branch
6 times, most recently
from
f7048cd to
1fcfe8f
Compare
roquelopez
force-pushed
the
top_value_matches
branch
from
1fcfe8f to
532b8d1
Compare
aecio
reviewed
Sep 16, 2024
|
I overlooked adding the test but will do so shortly, thanks! |
roquelopez
force-pushed
the
top_value_matches
branch
from
c917303 to
b6386b6
Compare
BREAKING CHANGE: this change may change the behavior of code that relies on edit being equal to True.
aecio
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
@roquelopez I made a few minor changes and commited the notebook/code. Feel free to merge when you review.
Comment on lines
+317
to
+321
| if "top_n" in method_args and method_args["top_n"] > 1: | ||
| logger.warning( | ||
| f"Ignoring 'top_n' argument, use the 'top_value_matches()' method to get top-k value matches." | ||
| ) | ||
| method_args["top_n"] = 1 |
There was a problem hiding this comment.
Instead of top_n, what about we use top_k to be consistent with other function parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is related to issue #61.