change: liberate VOICEVOX CORE #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2024
Hiroshiba
reviewed
Aug 30, 2024
|
VOICEVOX/voicevox_core#722 のため、libvoicevox_onnxruntimeではないようならば手前側でエラーとなるようにしました。 |
qryxip
force-pushed
the
change-liberate-voicevox-core
branch
from
cb4acff to
5b5b22a
Compare
Hiroshiba
approved these changes
Sep 1, 2024
| CStr::from_ptr(build_info) | ||
| .to_str() | ||
| .expect("should be UTF-8") | ||
| .starts_with("VOICEVOX ORT Build Info: ") |
There was a problem hiding this comment.
ここの文字列、大元の方を変えた時にこっちも変えるの忘れがちになるかもですね！
可能なら定数を定義して流用するのもありかも。
まあそんなに気にしなくてもいいと思うので、とりあえずこのプルリクエストではこのままで！
qryxip
added a commit
to VOICEVOX/voicevox_core
that referenced
this pull request
Nov 26, 2024
qryxip
added a commit
to VOICEVOX/voicevox_core
that referenced
this pull request
Jan 15, 2025
1. manifest.jsonの"…_filename"部分を変更し、.binを認識できるようにする。 .binの場合、 VOICEVOX/ort#8 で追加される `SessionBuilder::commit_from_vv_bin`を用いる。 ```json "predict_duration": { "type": "onnx", "filename": "predict_duration.onnx" }, ``` ```json "predict_duration": { "type": "vv_bin", "filename": "pd.bin" }, ``` 2. `Onnxruntime::LIB_NAME`を`"onnxruntime"`から`"voicevox_onnxruntime"` にする。compatible_engineの場合だけ、`"voicevox_onnxruntime"`で失敗す ると`"onnxruntime"`にフォールバックするようにする（モック目的で使える ように）。 3. VOICEVOX/ort#8 でログのフィルタリングをやめる代わりに、C APIのログ フィルタの`ort=info`を`ort=warn`にする。 4. build_and_deploy_downloaderの`is_production`周りを吹き飛ばす。 5. #913 の続きとして、Rust APIの`package.license`を設定。 残る課題は以下の通り。 > README周り（たぶんcore.zip内のreadmeは削除で良さそう？） > #825 (comment) > > downloader周り（一旦壊れることになる･･･？いやならなさそうな気がする！） > #825 (comment) > > is_productionフラグを失くす？ > #825 (comment) #825 (review) Resolves: VOICEVOX/voicevox_project#24 Resolves: #388 Resolves: #722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
SessionBuilder::commit_from_vv_binを追加し、暗号化対応ONNX Runtimeに暗号化ONNXを渡せるようにします。INFO以下のログをせき止めていたのをやめます。関連 Issue
ref VOICEVOX/voicevox_project#24
スクリーンショット・動画など
その他