chore: 初回ファイルの取得をbackendの関数として表現するようにする #2524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
|
PRありです！！ @sabonerune いつもすみません！何か気づいた点あればコメント頂けると心強いです…！ |
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/components/App.vue: Evaluated as low risk
- README.md: Evaluated as low risk
- src/backend/browser/sandbox.ts: Evaluated as low risk
- src/backend/electron/main.ts: Evaluated as low risk
|
自分の環境では問題なく動作しました。 Mac環境の場合はどうでしょうか? |
Hiroshiba
reviewed
Feb 11, 2025
There was a problem hiding this comment.
@sabonerune ありです！！！
macOSで試した感じ、確かにファイルがわたされてせんでした！
良い感じにコードがまとまってるなと思います！！
もっとリファクタリングできそう･･･！！
いっぱいコメントしていますが、すでに確かめるために変更済みのコードがあるのでPR送ります！！
どういう観点があるのかわかると思うので、コメントと見比べてみてください 🙏
|
すみません。。。。checkout -bしてからPRしようとしてたのですが、完全にミスってPRに直接pushしてしまいました。。。 🙇 🙇 🙇 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
backend.getInitialProjectFilePath()を追加します。関連 Issue
スクリーンショット・動画など
（なし）
その他
これのために
electron:serveに引数を渡せるような改修をしました。