Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mockのアセット取得をeagerにする #2539

Conversation

Hiroshiba
Copy link
Member

内容

eagerにしたほうがわかりやすそうだったので変更しました。
ついでに{default: string}も要らないことに気づいたので省きました。

その他

@Hiroshiba Hiroshiba requested a review from a team as a code owner February 16, 2025 15:46
@Hiroshiba Hiroshiba requested review from Copilot and removed request for a team February 16, 2025 15:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Hiroshiba
Copy link
Member Author

Hiroshiba commented Feb 19, 2025

手元だと通るテストがなぜか通らない・・・。よくわからないけどeagerはだめ・・・?

ちがう、eagerと一見関係ないところが通らなくなってる。

@Hiroshiba
Copy link
Member Author

@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:c77096a

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう。

@Hiroshiba
Copy link
Member Author

レビューありがとうございます、マージします!

@Hiroshiba Hiroshiba enabled auto-merge February 20, 2025 02:41
@Hiroshiba Hiroshiba added this pull request to the merge queue Feb 20, 2025
Merged via the queue into VOICEVOX:main with commit 914d815 Feb 20, 2025
11 checks passed
@Hiroshiba Hiroshiba deleted the chore--mockのアセット取得をeagerにする branch February 20, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants