Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
sevenc-nanashi
approved these changes
Feb 19, 2025
|
レビューありがとうございます、マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VvppManagerのテストを追加し、テストしやすいようにインターフェイスを変更します。
具体的にはVvppManagerにtmpDirを渡すようにし、electron.appへの依存をなくします。
あとVvppFileExtractorが中でエンジンディレクトリ書き出し先のパスを決めてたので、外で決めて渡せるようにします。
これでテストがやりやすくなるのでVvppManagerのテストを追加しました。
普通にVvppをインストールする・インストールしたあと上書きインストールする・アンインストールする挙動を試してます。
その他