Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: SHOW_EXPORT_FILE_DIALOGとSHOW_PROJECT_SAVE_DIALOGを統合 #2549

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Feb 19, 2025

内容

タイトルのとおりです。
ほとんど同じ処理をしていた関数2つを統合します。

関連 Issue

close #2543

スクリーンショット・動画など

その他

  • mainブランチのマージがいろいろ終わってから追従

@Hiroshiba Hiroshiba requested a review from a team as a code owner February 19, 2025 11:48
@Hiroshiba Hiroshiba marked this pull request as draft February 19, 2025 11:49
@Hiroshiba Hiroshiba force-pushed the refactor--SHOW_EXPORT_FILE_DIALOGとSHOW_PROJECT_SAVE_DIALOGを統合 branch from 6542d8f to b1764fd Compare February 19, 2025 11:58
@Hiroshiba Hiroshiba marked this pull request as ready for review February 19, 2025 11:58
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Feb 19, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:abd9601

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@Hiroshiba
Copy link
Member Author

レビューありがとうございます、マージします!

@Hiroshiba Hiroshiba enabled auto-merge February 20, 2025 03:30
@Hiroshiba Hiroshiba added this pull request to the merge queue Feb 20, 2025
Merged via the queue into VOICEVOX:main with commit ba39bd1 Feb 20, 2025
11 checks passed
@Hiroshiba Hiroshiba deleted the refactor--SHOW_EXPORT_FILE_DIALOGとSHOW_PROJECT_SAVE_DIALOGを統合 branch February 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リファクタリング:SHOW_EXPORT_FILE_DIALOGとSHOW_PROJECT_SAVE_DIALOGを統合
2 participants