Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: すべての依存をRenovateの対象にする #839

Merged
merged 22 commits into from
Sep 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
90aaa65
chore: すべての依存をRenovateの対象にする
qryxip Sep 26, 2024
ad28d7f
Add a comment
qryxip Sep 28, 2024
1656a41
[skip ci] Add a comment
qryxip Sep 28, 2024
23adf42
Add a comment
qryxip Sep 28, 2024
5847231
"{major,non-major} dependencies"について説明
qryxip Sep 28, 2024
9d20232
JSON5としてフォーマット
qryxip Sep 28, 2024
927d714
Revert "JSON5としてフォーマット"
qryxip Sep 28, 2024
a5ef979
末尾カンマだけ入れてみる
qryxip Sep 28, 2024
432e572
末尾カンマだけ入れる
qryxip Sep 28, 2024
322dcd7
Revert "末尾カンマだけ入れる"
qryxip Sep 28, 2024
392662b
mapの末尾にカンマを入れてみる
qryxip Sep 28, 2024
cf101d9
「arrayの末尾のobject」に末尾カンマを入れてみる
qryxip Sep 28, 2024
10ba553
Docker版でrenovate.json5を読んでみる
qryxip Sep 28, 2024
701d7fd
fixup! Docker版でrenovate.json5を読んでみる
qryxip Sep 28, 2024
0185235
Revert "「arrayの末尾のobject」に末尾カンマを入れてみる"
qryxip Sep 28, 2024
7574139
keyの`""`を外したらどうなるか?
qryxip Sep 28, 2024
13904f6
「arrayの末尾のobject」に対する末尾カンマだけ避けてJSON5化
qryxip Sep 28, 2024
3e47acf
Revert "fixup! Docker版でrenovate.json5を読んでみる"
qryxip Sep 28, 2024
79521af
Revert "Docker版でrenovate.json5を読んでみる"
qryxip Sep 28, 2024
84c641e
末尾カンマについての注意事項
qryxip Sep 28, 2024
6b8b92d
array末尾のobjectの末尾カンマを復活
qryxip Sep 28, 2024
53e35e5
Revert "末尾カンマについての注意事項"
qryxip Sep 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions renovate.json

This file was deleted.

78 changes: 78 additions & 0 deletions renovate.json5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Error executing gradle wrapper update command"のメッセージと共にgradle-wrapper.jarが消し飛ばされる件が気になるけど、どういう現象なのかまだわかってないし、Gradle自体のアップデートは別にやることで回避可能ではあるので除外設定はやらなくていいかなと思ってます。

Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:recommended"
],
"timezone": "Asia/Tokyo",
"separateMajorMinor": false,
Hiroshiba marked this conversation as resolved.
Show resolved Hide resolved
"dependencyDashboardApproval": true, // 万が一`packageRules`の網羅性に穴ができた場合に備え
"packageRules": [
{
qryxip marked this conversation as resolved.
Show resolved Hide resolved
"groupName": "major dependencies",
"matchUpdateTypes": [
"major"
],
"dependencyDashboardApproval": false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

折角JSON5にしたので、末尾カンマ入れてもいいかも?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

どちらでも良さそう! どちらかというと入れた方がいい気がしますね!

Copy link
Member Author

@qryxip qryxip Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9d20232 (#839)
JSON5としてフォーマットした…のですがこれは…
image
"renovate.json5"を受け付けると言いつつ実はJSONCまでしか受け付けないとか…? (ありえそう)

[追記] 末尾カンマは大丈夫っぽい?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いやこれよくわからないな。末尾カンマはOKなのかそうじゃないのか…???

Copy link
Member Author

@qryxip qryxip Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

検証したところ「arrayの末尾にあるobjectに対する末尾カンマ」(},)だけ、GitHub App版のRenovateにだけ通らないみたいです。
Discord: https://discord.com/channels/879570910208733277/893889888208977960/1289475175066370099

基本JSON5にしつつGitHub App版には通るようにして、コメントで注意書きという形ですかね…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意書きのコメントはこうなりました。
cdb6d50 (#839)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

えーと今 (09-28 19:00くらい)報告用の最小例を作ろうとしたら再現せず、このPRでの末尾カンマを復活させたらGitHub App版も普通に動きました… 何だかわからないけど一過性のものだった?

6b8b92d (#839)
53e35e5 (#839)

},
{
"groupName": "major dependencies",
"matchUpdateTypes": [
"minor"
],
"matchCurrentVersion": "/^v?0\\./",
"dependencyDashboardApproval": false
},
{
"groupName": "major dependencies",
"matchUpdateTypes": [
"patch"
],
"matchCurrentVersion": "/^v?0\\.0\\./",
"dependencyDashboardApproval": false
},
{
qryxip marked this conversation as resolved.
Show resolved Hide resolved
"groupName": "non-major dependencies",
"matchUpdateTypes": [
"minor"
],
"matchCurrentVersion": "!/^v?0\\./",
"dependencyDashboardApproval": false
},
{
"groupName": "non-major dependencies",
"matchUpdateTypes": [
"patch"
],
"matchCurrentVersion": "!/^v?0\\.0\\./",
"dependencyDashboardApproval": false
},
{
Hiroshiba marked this conversation as resolved.
Show resolved Hide resolved
"matchDatasources": [
"github-runners"
],
"matchPackageNames": [
"windows",
"macos",
"ubuntu"
],
"enabled": false
}
],
"cargo": {
"rangeStrategy": "bump"
},
"customManagers": [
{
"customType": "regex",
"fileMatch": [
"^rust-toolchain$"
],
"matchStrings": [
"(?<currentValue>\\d+\\.\\d+\\.\\d+)"
],
"depNameTemplate": "Rust",
"packageNameTemplate": "rust-lang/rust",
"datasourceTemplate": "github-tags"
}
]
}
Loading