fix: fix up #893: add missing shell: bash
#904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
LGTM！！
（ただのコメントですが）
shell: bash忘れるというか、特に新規コミッターの方の初見殺しになっちゃうので、shellを使うかどうかに関わらず全部のymlに
defaults:
run:
shell: bashを書くのが良いかな～と漠然と思ってたのですが、やっぱそうしたほうが心配ごと減って良いかもしれないですね！
ちなみにエンジンとエディタはそうなってます
https://github.com/VOICEVOX/voicevox_engine/blob/5e755b662b8e79bc2ce8c011ae8064ed7b0e10b8/.github/workflows/build-engine-package.yml#L31-L33
でも不格好な気もするし、悩みどころだなぁ。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#893 (comment)
関連 Issue
その他