Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-s] sing追加してデフォルトをtalkにする #1030

Merged
merged 2 commits into from
Jan 27, 2024
Merged

[project-s] sing追加してデフォルトをtalkにする #1030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6a9cd
sing追加してデフォルトをtalkにする
Hiroshiba Jan 27, 2024
2de2be1
test
Hiroshiba Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/e2e/__snapshots__/test_openapi/test_OpenAPIの形が変わっていないことを確認.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,10 +725,12 @@
"type": "string"
},
"type": {
"default": "talk",
"enum": [
"talk",
"humming",
"sing_teacher"
"sing_teacher",
"sing"
],
"title": "モデルの種類",
"type": "string"
Expand Down
20 changes: 10 additions & 10 deletions test/e2e/__snapshots__/test_validate_speakers/test_fetch_speakers_success.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@
{
"id": 0,
"name": "style0",
"type": null
"type": "talk"
},
{
"id": 2,
"name": "style1",
"type": null
"type": "talk"
},
{
"id": 4,
"name": "style2",
"type": null
"type": "talk"
},
{
"id": 6,
"name": "style3",
"type": null
"type": "talk"
}
],
"supported_features": {
Expand All @@ -36,22 +36,22 @@
{
"id": 1,
"name": "style0",
"type": null
"type": "talk"
},
{
"id": 3,
"name": "style1",
"type": null
"type": "talk"
},
{
"id": 5,
"name": "style2",
"type": null
"type": "talk"
},
{
"id": 7,
"name": "style3",
"type": null
"type": "talk"
}
],
"supported_features": {
Expand All @@ -66,7 +66,7 @@
{
"id": 8,
"name": "style0",
"type": null
"type": "talk"
}
],
"supported_features": {
Expand All @@ -81,7 +81,7 @@
{
"id": 9,
"name": "style0",
"type": null
"type": "talk"
}
],
"supported_features": {
Expand Down
4 changes: 2 additions & 2 deletions voicevox_engine/metas/Metas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# NOTE: 循環importを防ぐためにとりあえずここに書いている
# FIXME: 他のmodelに依存せず、全modelから参照できる場所に配置する
StyleId = NewType("StyleId", int)
StyleType = Literal["talk", "humming", "sing_teacher"]
StyleType = Literal["talk", "humming", "sing_teacher", "sing"]


class SpeakerStyle(BaseModel):
Expand All @@ -16,7 +16,7 @@ class SpeakerStyle(BaseModel):

name: str = Field(title="スタイル名")
id: StyleId = Field(title="スタイルID")
type: Optional[StyleType] = Field(title="モデルの種類")
type: Optional[StyleType] = Field(default="talk", title="モデルの種類")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デフォルト値をtalkにしています。たぶん問題ないと思うのですが一応共有です。 @y-chan

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エディタ側のOpenAPIのPR見ても、そっちに影響があるわけではなさそうだったので、とりあえずよいのかなと思いました...!



class SpeakerSupportPermittedSynthesisMorphing(str, Enum):
Expand Down
Loading