Fix Fabric transfer transaction usage #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TheRealWormbo
commented
Dec 13, 2023
TheRealWormbo
commented
- access simulated extract operations in transaction as well (fixes Corporea Crystal Cube causing ticking block entity crash #4486)
- get rid of the inner transaction, as commit or rollback depends on the spark type and thus is identical for all accesses within the outer transaction (as recommended in Corpoera sparks iterate storage views outside transaction #4403)
- ensure to commit the outer transaction after iterating over the slots if extracting via non-creative spark
- access simulated extract operations in transaction as well - get rid of the inner transaction, as commit or rollback depends on the spark type and thus is identical for all accesses within the outer transaction (as recommended in VazkiiMods#4403) - ensure to commit the outer transaction after iterating over the slots if extracting via non-creative spark
|
thank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.