Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipeline generalization #5

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Conversation

VemundFredriksen
Copy link
Owner

Pull Request

Description

Small adjustments to the Tumor Isolation Pipeline and the folderstructure of assets

  • Generalize the TumorIsolation-transform so it can be used in Compose() without the need to temporarily store files on disk in between transforms
  • Place formatted images directly into /assets/source/ rather than in specific dataset folder (/assets/source/msd/)
  • Place seed images directly into /assets/seeds/ rather than in specific dataset folder (/assets/seeds/msd/)

Type of Change

  • Bug Fix
  • New Feature
  • Documentation Update
  • Code Refactoring
  • Other (please describe)

Checklist

  • I have reviewed the code to ensure it follows the project's coding standards.
  • I have tested the changes locally to verify that they work as expected.
  • I have updated the documentation if necessary.

Screenshots

- Makes it possible to insert just the TumorSeedIsolationd()-transform into a larger pipeline without the need to temporarily store the results on disk
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

3.1% 3.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sosevle sosevle merged commit a759560 into main Oct 29, 2023
2 of 3 checks passed
@sosevle sosevle deleted the refactor-pipeline-generalization branch October 29, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants