Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tumor insertion improvement #6

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Tumor insertion improvement #6

merged 3 commits into from
Nov 10, 2023

Conversation

sosevle
Copy link
Collaborator

@sosevle sosevle commented Nov 5, 2023 •
edited
Loading

Pull Request

Description

This PR enables new feature...

Type of Change

  • Bug Fix
  • New Feature
  • Documentation Update
  • Code Refactoring
  • Other (please describe)

Checklist

  • I have reviewed the code to ensure it follows the project's coding standards.
  • I have tested the changes locally to verify that they work as expected.
  • I have updated the documentation if necessary.

Screenshots

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability D 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 5, 2023
View reviewed changes
synthlung/utils/tumor_insertion_pipeline.py

print(jsonData)

requests.post(url, data=jsonData, headers=header, verify=False)

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections High

Enable server certificate validation on this SSL/TLS connection. See more on SonarCloud
VemundFredriksen
VemundFredriksen approved these changes Nov 9, 2023
View reviewed changes
Copy link
Owner

@VemundFredriksen VemundFredriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initial start, we can evaluate the security concern later; for now its only logging to localhost, there are no sensitive data that is transmitted and the logging isnt even enabled.

@sosevle sosevle merged commit c632e15 into main Nov 10, 2023
1 of 3 checks passed
@sosevle sosevle deleted the tumor_insertion_improvement branch November 10, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VemundFredriksen VemundFredriksen VemundFredriksen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sosevle @VemundFredriksen