Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes to the Article class #1865

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Eitot
Copy link
Contributor

@Eitot Eitot commented Dec 18, 2024

  • Replaces -markRead:, -markDeleted: etc. methods in the Article class with read–write properties
    This simplifies the interface of the class. I could not find a reason why the -markX: methods were used instead of making the corresponding properties writable.
  • Changes the type of status property of the Article class from NSInteger to ArticleStatus
    This provides better compatibility with Swift.
  • Uses automatically synthesised ivars and accessors in the Article class
    This gets rid of needless boilerplate code.
  • Extends the NS_ASSUME_NONNULL_* annotation block to cover the whole Article class
  • Declares the designated initialiser of the Article class and marks the inherited -init method as unavailable
  • Uses ivars instead of the dictionary for certain properties in the Article class
    These properties are set in the initialiser, whereas other properties may not be set at all.
  • Expands article unit tests to test initial values of the Article class
  • Removes duplicate test methods from the VNAArticleTest class
  • Renames VNAArticleTests.m to ArticleTests.m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant