-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/improve description #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup 👍. I have only one minor question that we can probably just monitor at this point in case we find some odd behaviour in the future.
description="species to be observed after each scan." | ||
" These are the species whose concentration" | ||
" will be observed after the parameter scan." | ||
" Do not make up this data.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
@@ -8,19 +8,33 @@ | |||
import operator | |||
from langgraph.prebuilt.chat_agent_executor import AgentState | |||
|
|||
def add_data(data1: dict, data2: dict) -> dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been tested for when there are concurrent writes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmccloskey
I monitored this by viewing logs in the Streamlit code and confirmed that it handles concurrent writing correctly. Anyway, in one of the upcoming PRs, I’ll add a pytest too to cover this. Thanks!
🎉 This PR is included in version 1.14.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
For authors
Description
In this PR, I'd like to propose changes to enhance the readability and efficiency of the codebase by implementing the following improvements:
operator.add
. See Support Clearing Annotated[list, operator.add] Fields in LangGraph State langchain-ai/langgraph#2944test_langgraph.py
) into multiple focused tests, enabling a one-to-one mapping with corresponding tools.steady_state
andsimulate_model
tools to eliminate redundancy.param_scan
tool to extend its functionality FEATURE: parameter scanning #20.Fixes # (issue) #20 #78
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.
tests
foldertests/testX.py
)Checklist
tests
folder) that prove my fix is effective or that my feature worksFor reviewers
Checklist pre-approval
Checklist post-approval
develop
intomain
? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.Checklist post-merge
develop
intomain
and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.