Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in cluster mysql #16

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Fix in cluster mysql #16

wants to merge 26 commits into from

Conversation

palla714
Copy link

This PR is to add a condition to disable the MySql pvc deployment for PROD cluster as for PROD cluster managed databases are already present

##Build Job URL##
https://jenkins-labs-ci-cd.apps.dev.lxp.academy.who.int/job/badgr-server/job/fix-in-cluster-mysql/2/

##Build URL ##
http://fix-in-cluster-mysql-badgr-server-labs-dev.apps.dev.lxp.academy.who.int/

Since for PROD cluster managed database are already present
@palla714 palla714 requested a review from gkmahendran09 April 21, 2022 13:25
@@ -1,4 +1,4 @@
{{- if and .Values.persistence.enabled (not .Values.persistence.existingClaim) }}
{{- if and .Values.persistence.enabled (not .Values.persistence.existingClaim) (not .Values.managedDatabase.enabled) }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this condition for all the MySQL config, only with this change, the rest of the MySQL components will be deployed but without the PVC it will eventually fail.

Also, while testing set managedDatabase.enabled: true in the development branch, and create a public managed MySQL server for testing purpose and use its credential to test it.

managedDatabase:
enabled: false
host: dummyval
user: dummyval
name: dummyval
password: dummyval

I also see there are a lot of MySQL config files here, which are created long back, it is a good opportunity to refactor this.
image

Can you remove all the MySQL config files and use the Bitnami MySQL chart and update the badger's deployment configs accordingly?

you can refer to this implementation - https://github.com/WHOAcademy/learning-delivery-api/blob/main/chart/Chart.yaml#L25-L29

@krishnamadhavan @eddiebarry FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants