Fix Pyplot, Add unit tests #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased. |
jpthiele
approved these changes
Nov 28, 2024
|
@jpthiele BTW, merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue from comment #39 (comment)
I still plot a dummy triangle, but now it is explicitly constructed as the first triangle of the triangulation.
Also, CI is extended by a test for PyPlot and PlutoVista, as requested in #53. The new test would have caught the issue from before.
I hope the tests run headless, at least they did on my machine :)
I used the chance to merge the
Project.tomlfrom the test folder into the main one.