Document an edge case with join / win history #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to join / bid history being floored to a multiple of UTC days, there's a possibility that the interest group outlives its history, even if it isn't rejoined. This leads to oddities like interest groups with a join count of 0. Fix this by letting history live for one more day.
|
@brusshamilton -- for some reason, I can't add you as a reviewer? |
I wonder if it's due to missing some permission on the repository? @JensenPaul -- could you take a look? Thanks :) |
brusshamilton
approved these changes
Dec 12, 2024
caraitto
changed the title
|
PTAL, I re-wrote this since we decided to just keep (and document) the existing behavior. |
brusshamilton
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to join / bid history being floored to a multiple of UTC days, there's a possibility that the interest group outlives its history, even if it isn't rejoined. This leads to oddities like interest groups with a join count of 0.
Document this behavior, but don't change it.
Preview | Diff