Wallet: Remove the requirement to be authenticated, add fallback when no location is set #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsluijk
requested review from
JoepdeJong,
07joshua03,
maartenweyns and
VicVsl
JoepdeJong
requested changes
Sep 29, 2024
JoepdeJong
approved these changes
Sep 29, 2024
|
@dsluijk i just noticed, as authenticationService is not required anymore, it can be removed from the initializer of the WebshopPassesController. can you look at this? |
|
I believe this is still required for other subclasses of the WebshopController superclass. So I don't think we can do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People are running into a generic error when trying to add a ticket to their {Apple, Google} Wallet. Since the ticket key is sufficiently random, we can just remove the requirement to be authenticated.
Secondly for the Google Wallet we get an error when no location is set for a ticket. This also adds a fallback location (Unknown), so it still proceeds.