Add a public route for upcoming events #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have something like this right? The iCal thingy. That's what I use for the upcoming events narrowcast tv screen. But I guess this is a bit cleaner haha |
|
Yes, the same information is available though the calendar feed, but this is fetched from the events store in the website. This is then synced with events through webhooks. I want to add this route for when we would replace that system e.g. when we have a new website |
|
Ooo that's via the website, I forgot that. Clear now! |
|
|
ThomBreugelmans
approved these changes
Oct 2, 2024
|
For what will this be used? Product also have a sellEnd date. Do you think we need to filter on that too, instead on just the upcoming events? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a public route which can be used to fetch the upcoming events. This is useful as this can be the source of truth when it comes to CH events, and can then be fetched in an automated fashion. Private information is stripped from the response, and only published events are shown.