Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add administration costs #510

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Add administration costs #510

merged 9 commits into from
Nov 13, 2024

Conversation

robertdijk
Copy link
Member

@robertdijk robertdijk commented Oct 26, 2024

Add administration costs to each order. The value can be set in the application.yml. When the value of the products is 0, the administration costs will be 0.

This pr also shows the costs on the order overview page, and the shopping basked, and in the mail, and in the order on the admin panel. Basically all the places I could find.

Todo:

  • Implement VAT for the administration costs.
  • Test database migration

@robertdijk
Copy link
Member Author

Robine said VAT does not have to be implemented since there is.not VAT on administration costs.

@robertdijk
Copy link
Member Author

Can we test the database migration? or should we just try it?

@robertdijk robertdijk changed the title Draft: Add administration costs Add administration costs Oct 27, 2024
@JoepdeJong
Copy link
Contributor

Can we test the database migration? or should we just try it?

at the moment, no, as there is no schema dump of the production environment available.

@07joshua03
Copy link
Contributor

Good tests, lgtm

would've been better to put in treasurer tab, but fine as is.

@07joshua03 07joshua03 merged commit 7d071fc into master Nov 13, 2024
5 checks passed
@07joshua03 07joshua03 deleted the feature-adminstation_costs branch November 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants