-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
working with gc types #317
Draft
oovm
wants to merge
6
commits into
WebAssembly:main
Choose a base branch
from
oovm:gc-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1d6566d
Add reference type mapping
oovm a48d24c
distinguish the layout of option scalar and option reference types
oovm 75d5925
Remove reference type options
oovm 4e98fd2
Merge branch 'WebAssembly:main' into gc-integration
oovm b18bd02
Merge remote-tracking branch 'origin/main' into gc-integration
oovm 1f74456
revert python changes
oovm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right place to put this spec information is in CanonicalABI.md (along-side the current spec information for how non-gc works) and in
canonical-abi/definitions.py
(which has the benefit that you can write tests for it inrun_tests.py
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to rewrite
definitions.py
. The binary needs to reference an index of an already defined type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
definitions.py
is not a complete Python reference implementation but, rather, just a "suggestive" subset that describes just the lifting/lowering/built-in rules, what we do is, forcanon
definitions that take atypeidx
in the binary format, we have the correspondingcanon_*
Python function take a Python object that directly represents the type (e.g., see howcanon_lift
takes aFuncType
directly). That being said, I don't think there are any cases where you'll need to take a core wasm gc type as an immediate -- core wasm types are programmatically derived from component-level types by, e.g.,flatten_functype
which is called bycanon_lift
andcanon_lower
. Thus, I think you just need to addCoreArrayType
andCoreStructType
Python classes (analogous toCoreFuncType
) so they can be created byflatten_functype
in the appropriate cases whencx.opts.gc
is true (which you'd also add toCanonicalOptions
.