chore(*): change world name to imports and add package version #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
| @@ -1,5 +1,3 @@ | |||
| package wasi:blobstore; | |||
There was a problem hiding this comment.
Shouldn't all of these be package wasi:[email protected] and not removed?
There was a problem hiding this comment.
I think one declaration of package is sufficient, no?
There was a problem hiding this comment.
I thought it was per file, but then I ran into other examples where it wasn't the case.
There was a problem hiding this comment.
Cool it seems like we are aligned here. Could you please give it another review and so I can merge it once it's approved.
thomastaylor312
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wit/world.wit: Added a package version towasi:blobstorepackage with version0.1.0and changed world name to imports