fix: add outgoing-value.finish
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without an explicit `outgoing-value.finish`, the host may not know when the data stream has finished and when to stop writing. Additionally, this allows for errors to be communicated to the guest, which may have happened asynchronously Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
force-pushed
the
fix/outgoing-value-finish
branch
from
ba8b549 to
18f1288
Compare
thomastaylor312
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without an explicit
outgoing-value.finish, the host may not know when the data stream has finished and when to stop writing.Additionally, this allows for errors to be communicated to the guest, which may have happened asynchronously