-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate field-key
in favor of field-name
#127
Deprecate field-key
in favor of field-name
#127
Conversation
The PR updating this only caught the 0.3-draft APIs, presumably by accident. Including it in this change since we're touching the header names already.
515e6ae
to
103dded
Compare
Changing this to a draft PR: |
103dded
to
84a99f4
Compare
This needs WebAssembly/wit-abi-up-to-date#28 to land and be published so we can update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Cool to see @deprecated in action.
Co-Authored-By: Luke Wagner <[email protected]>
Co-Authored-By: Luke Wagner <[email protected]>
Co-Authored-By: Luke Wagner <[email protected]>
Realized just now that we'd set the
|
Closes #107.
This deprecates
field-key
in favor offield-name
using the@deprecated
attribute in WIT. This is the first deprecation we're running in WASI, making this the first field test of it in our tooling. The way I've implemented the type change is by doing the following:I don't know WIT's type system well enough to know whether I could instead just have written:
This PR also catches a case for #117 that #121 missed: only the
0.3.0-draft
APIs had their prose text updated about casing. That seemed to be on accident - and since we're touching thefield-key
API's text anyway, that seemed like something easy to include here.Thanks!