Fix CI by enabling all features #152
Merged
+45
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see: CI fails if the 0.3 deps are not also updated. Apologies to @rvolosatovs, I didn't realize both parts of the PR were needed. Running |
ricochet
reviewed
Feb 7, 2025
| @@ -1,12 +1,12 @@ | |||
| [cli] | |||
| url = "https://github.com/WebAssembly/wasi-cli/archive/v0.2.3.tar.gz" | |||
There was a problem hiding this comment.
0.3-draft in the lock but this does fix ci for now
ricochet
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to #151 using WebAssembly/wit-abi-up-to-date#29 to enable all features in CI. This approach has precedent in e.g.
wasi:cli, where we generate docs for the unstablecli-exit-with-codefeature.Assuming this PR passes CI, #151 can be trimmed down to just upgrading the 0.3 draft's dependencies. And in a future PR we should address the issue @rvolosatovs pointed out where PRs filed by GitHub Actions do not trigger CI runs.
Thanks!