Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to ensure config files are accessed from absolute paths #227

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

pfeairheller
Copy link
Member

The PR ensures config files are accessed from absolute paths not relative to where the test is being run.

The previous behavior was causing the creation of new empty config files if tests were run from anywhere but the root directory of project.

… not relative to where the test is being run.

Signed-off-by: pfeairheller <[email protected]>
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (5f06007) to head (bf92386).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   93.08%   92.81%   -0.28%     
==========================================
  Files          38       37       -1     
  Lines        7002     6974      -28     
==========================================
- Hits         6518     6473      -45     
- Misses        484      501      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pfeairheller pfeairheller merged commit f0be9b6 into WebOfTrust:main Apr 8, 2024
5 checks passed
@pfeairheller pfeairheller deleted the fix-test-files branch April 8, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant