feat: basic protection boot endpoint #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 93.06% 93.86% +0.79%
==========================================
Files 36 36
Lines 7121 8147 +1026
==========================================
+ Hits 6627 7647 +1020
- Misses 494 500 +6 ☔ View full report in Codecov by Sentry. |
iFergal
reviewed
Dec 9, 2024
iFergal
approved these changes
Dec 9, 2024
lenkan
force-pushed
the
feat-boot-protection
branch
from
8610df9 to
fe75188
Compare
lenkan
added a commit
to nordlei/keria
that referenced
this pull request
Dec 12, 2024
* feat: basic protection boot endpoint * rename env variable to indicate experimental status * update with more test cases * add command line flags for boot protection
lenkan
added a commit
to nordlei/keria
that referenced
this pull request
Dec 12, 2024
* feat: basic protection boot endpoint * rename env variable to indicate experimental status * update with more test cases * add command line flags for boot protection
lenkan
added a commit
to nordlei/keria
that referenced
this pull request
Dec 12, 2024
* feat: basic protection boot endpoint * rename env variable to indicate experimental status * update with more test cases * add command line flags for boot protection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a basic protection of the boot endpoint, this enables you to more easily deploy test instances publicly. This way you can add the authorization to the URL. See rationale in #327
Closes #327
If we also land #333, I will rebase this on top and also expose this feature as command line flags.
I also thought this could be implemented as a falcon middleware. But wanted to get feedback first whether or not it should be included at all.