Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: 400 for invalid end role signatures" #347

Closed
wants to merge 1 commit into from
Closed

Revert "fix: 400 for invalid end role signatures" #347

wants to merge 1 commit into from

Conversation

kentbull
Copy link
Contributor

Reverts #344, as the UnverifiedReplyError is a part of the normal operations of the reply message escrows and should not result in a 400 error being sent to the SignifyTS client.

@kentbull kentbull requested review from m00sey and iFergal January 10, 2025 17:24
@iFergal
Copy link
Collaborator

iFergal commented Jan 10, 2025

@kentbull please see the PR i opened last week to correct: #346

This reverts UnverifiedReplyError but keeps the new logic to make sure the signature is correct.

@kentbull
Copy link
Contributor Author

oh, okay, I'll go take a look at that and close this one.

@kentbull kentbull closed this Jan 10, 2025
@kentbull kentbull deleted the revert-344-fix/endRole400 branch January 13, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00sey m00sey Awaiting requested review from m00sey

@iFergal iFergal Awaiting requested review from iFergal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentbull @iFergal