Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds docker support for multiple architectures #832

Merged
merged 2 commits into from
Aug 12, 2024
Merged

adds docker support for multiple architectures #832

merged 2 commits into from
Aug 12, 2024

Conversation

m00sey
Copy link
Member

@m00sey m00sey commented Jul 30, 2024

Attempts to address #831

Updates the Makefile to use the docker build command with --platform and multiple architectures argument.

This required a change to the local Docker (for Desktop) installation being used to create the images.

In order to use the multi-platform build enable the containerd image store
The containerd image store is not enabled by default.
To enable the feature for Docker Desktop:
	Navigate to Settings in Docker Desktop.
	In the General tab, check Use containerd for pulling and storing images.
	Select Apply and Restart.

The result is build referencing multiple architectures:

Screenshot 2024-07-31 at 11 40 38 AM

Screenshot 2024-07-31 at 11 40 08 AM

@m00sey m00sey marked this pull request as draft July 30, 2024 15:44
@m00sey m00sey marked this pull request as ready for review July 30, 2024 15:57
@m00sey m00sey marked this pull request as draft July 30, 2024 16:53
@m00sey m00sey force-pushed the fr/831 branch 2 times, most recently from f1dd259 to 9befcfa Compare July 31, 2024 15:45
m00sey added 2 commits July 31, 2024 11:47
Signed-off-by: Kevin Griffin <[email protected]>
@m00sey m00sey marked this pull request as ready for review July 31, 2024 15:48
@m00sey m00sey requested a review from pfeairheller July 31, 2024 17:03
@m00sey m00sey changed the title adds docker manifest for multiple architectures adds docker support for multiple architectures Jul 31, 2024
@pfeairheller pfeairheller merged commit 8082f7e into main Aug 12, 2024
6 checks passed
@pfeairheller pfeairheller deleted the fr/831 branch August 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants