signedFetch more generic/configurable aligning it with fetch api #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 2byrds <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 83.42% 83.51% +0.08%
==========================================
Files 46 46
Lines 4218 4210 -8
Branches 1052 1047 -5
==========================================
- Hits 3519 3516 -3
+ Misses 671 666 -5
Partials 28 28 ☔ View full report in Codecov by Sentry. |
lenkan
reviewed
May 8, 2024
…ect. starting to remove hard coded header names Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
lenkan
requested changes
May 12, 2024
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
|
@lenkan latest changes per your recommendations have been added. |
lenkan
reviewed
May 15, 2024
lenkan
reviewed
May 15, 2024
Signed-off-by: 2byrds <[email protected]>
|
thank you for fixes @lenkan i have updated it per your suggestions |
lenkan
reviewed
May 16, 2024
Signed-off-by: 2byrds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.