Skip to content

Commit

Permalink
added timeout for subprocess
Browse files Browse the repository at this point in the history
this is so we dont wait infinite if something goes wrong
  • Loading branch information
7h3Rabbit committed Feb 5, 2024
1 parent 4e9dd3f commit 4648cea
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/sitespeed_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def get_result_using_no_cache(sitespeed_use_docker, arg):

import subprocess
process = subprocess.Popen(bashCommand.split(), stdout=subprocess.PIPE)
output, error = process.communicate()
output, error = process.communicate(timeout=request_timeout)

if error != None:
print('DEBUG get_result_using_no_cache(error)', error)
Expand All @@ -131,7 +131,7 @@ def get_result_using_no_cache(sitespeed_use_docker, arg):
process = subprocess.Popen(
bashCommand.split(), stdout=subprocess.PIPE)

output, error = process.communicate()
output, error = process.communicate(timeout=request_timeout)

if error != None:
print('DEBUG get_result_using_no_cache(error)', error)
Expand Down

0 comments on commit 4648cea

Please sign in to comment.