Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions: Optional GITHUB SECRETS for Regression Tests #719

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

cockroacher
Copy link
Collaborator

Summary:
This PR modifies our GitHub Actions workflow for regression tests to make the use of GITHUB SECRETS optional. While still highly recommended for storing URLs to licensed resources like the IP2Location database, this change ensures that the workflow can run without them.

Details:

  • Updated the workflow configuration to handle the absence of GITHUB SECRETS.
  • Added fallback mechanisms to ensure tests can still execute without access to licensed resources.

Benefits:

  • Increases flexibility and ease of use for contributors.
  • Ensures that regression tests can run in environments where GITHUB SECRETS are not available.
  • Maintains security and best practices by recommending the use of GITHUB SECRETS.

Testing:

  • Verified that the workflow runs successfully with and without GITHUB SECRETS.
  • Ensured that appropriate warnings are logged when GITHUB SECRETS are not used.

@cockroacher cockroacher merged commit fc9c65e into main Nov 12, 2024
19 of 23 checks passed
@cockroacher cockroacher deleted the regression-success-improvement branch November 12, 2024 19:09
@github-actions github-actions bot restored the regression-success-improvement branch November 12, 2024 20:05
@7h3Rabbit 7h3Rabbit deleted the regression-success-improvement branch November 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant