Make aspect multi select input #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvelez17
reviewed
Aug 6, 2023
| @@ -174,7 +174,7 @@ export const Form = ({ | |||
| setValue('object', '') | |||
| } else { | |||
| setValue('stars', null) | |||
| setValue('aspect', '') | |||
| setValue('aspect', []) | |||
There was a problem hiding this comment.
yeah so we want this, but it requires other changes actually on front end - we have to create multiple claims and sign and submit all, in front end
because back end can't sign a claim
There was a problem hiding this comment.
yeh we know we make it till we change in the data model
gvelez17
requested changes
Aug 6, 2023
There was a problem hiding this comment.
this is great but - we have to have capability to make multiple claims from front end, or we have to change the data model for aspect to be a list
so we want the ability for aspect to be a list but we can NOT merge this as it is without making other changes to support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.