Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set both include_dirs and include_path for rebar3 deps #13

Closed
wants to merge 1 commit into from

Conversation

filmor
Copy link
Contributor

@filmor filmor commented Dec 8, 2023

This is a follow up of WhatsApp/eqwalizer#49 to set both the include_dirs and include_path entries for apps that are created from rebar3 build-info.

Explanation: WhatsApp/eqwalizer#49 (comment)

@perehonchuk
Copy link
Contributor

perehonchuk commented Dec 18, 2023

@filmor thanks for your contribution. We already set include_path here. The only difference between your PR and what we have now is that you setting the include_path for deps. I am not sure I understand your usecase, but could you try setting the include_path for deps in Rebar::new like we do for apps and check if it helps?

@facebook-github-bot
Copy link
Contributor

@robertoaloi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@robertoaloi merged this pull request in b33b594.

@robertoaloi
Copy link
Contributor

Thanks for your contribution @filmor and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants