Restore OTP 25 support

[belltoy]

I've read about the failure mentioned in #37. It's because the erlang_service uses the new map comprehension syntax introduced in OTP 26.

Only three places use the new syntax. Can we restore OTP 25 support by replacing the map comprehension with the legacy maps:to_list/maps:from_list? I have built the elp based on 2024-07-16 and 2024-08-05, seems to work fine.

[robertoaloi]

@belltoy Thanks for this. I don't have a problem restoring OTP 25 support via this patch. But in CI we can only vscode-publish one entry. I'd go for OTP 25 to maximize compatibility. So, please modify one of the flags to false.

[belltoy]

Updated and rebased.

[robertoaloi]

Why is there a change in the Cargo.lock file?

[belltoy]

Every time I run cargo build, cargo will always give that change. It seems there should be the source and checksum field there.

[belltoy]

The reason why there is a change in my compilation is that cargo uses oss tree-sitter-erlang dep from crates.io instead of a local fb-only tree-sitter-erlang folder.

https://github.com/WhatsApp/erlang-language-platform/blob/main/Cargo.toml#L101-L102

# @fb-only: tree-sitter-erlang = { path = "./tree-sitter-erlang" }
tree-sitter-erlang = "0.7.0" # @oss-only

I guess the annotation @fb-only and @oss-only are taken by a Facebook internal tool, which works like the patch in cargo. I can reproduce this via patch in Cargo.toml:

[patch.crates-io]
tree-sitter-erlang = { path = "path/to/tree-sitter-erlang" }

And run the cargo build, the source and checksum fields will be removed by cargo, just like the lock file in the repo.

IMO, adding the two fields back to the lock file should be a fix for the open source version.

[facebook-github-bot]

@robertoaloi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[robertoaloi]

IMO, adding the two fields back to the lock file should be a fix for the open source version.

Unfortunately accepting those two lines breaks in the internal tooling/CI. We are discussing how to make it work for both versions. In the meantime I will patch it and get this one in!

[facebook-github-bot]

@robertoaloi merged this pull request in 8b8eb2e.

[belltoy]

Thanks, Roberto.

[robertoaloi]

Thank you for the contribution!