Prevent completion within comments #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertoaloi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
It makes sense to me, thanks for the contribution! |
|
@robertoaloi merged this pull request in a9170fd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches rust-analyzer's behavior in comments: completions are avoided completely. Ocassionally the completions can be useful (for example completing a parameter while writing docs for a function) but on balance I think the completions are noisier than they are helpful. Maybe there's room in the long run to be smarter about completions in comments (similar to rust-analyzer#4170) but without that I think it's better to avoid completions in comments entirely.