Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT allow to set environment variable at install #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glemaitre
Copy link

This is not practical to hard code flag_MSCV since that one can need to install the package from pip without editing the setup.py. In this regard, I did a small hack to read an environment variable to turn ON/OFF the flag for the install.

@Who8MyLunch
Copy link
Owner

@glemaitre I updated the setup.py file to check the system platform type before setting any specific compiler or linker options. This is prefered over setting/reading environment variables.

@glemaitre
Copy link
Author

glemaitre commented Feb 18, 2018 via email

@Who8MyLunch
Copy link
Owner

@glemaitre yikes I cannot believe how difficult this became! I don't know the 'best' way to set these options that also allows for MINGW, and I just spent half my morning unsuccessfully trying to figure it out. For now I've removed the platform-specific compiler arguments.

@glemaitre
Copy link
Author

glemaitre commented Feb 18, 2018 via email

@Who8MyLunch
Copy link
Owner

Passing options at pip CLI would be perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants