New SolarEdgeACEnergy class #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backwards compat change: default name no longer includes units.
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New class has various improvements and now uses the inverter's native watt-hour units.
Backwards compatibility note: units have been removed from the energy (kWh) sensor names and entity names. This will affect new users to the integration that use templates intended for older versions. Upgrading as an existing user does not change existing entity names.
The decision to use fixed units in kWh predates the ability for Home Assistant users to select display precision and dynamically convert between units in a supported sensor class. But now that users can change the units and precision in the UI, having "kwh" in the sensor name is no longer appropriate and possibly inaccurate.