New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some nice changes to getAvatarMaterial #2

Open

Srlion wants to merge 5 commits into WilliamVenner:master from Srlion:master

Srlion commented Dec 29, 2024

Use PNG as file ext, no need to check file ext type, as Material function will work even if the file format doesn't match.
Fix a bug where it never loads from cache because it was checking if 100 (example) > AVATAR_IMAGE_CACHE_EXPIRES = 86400 (It only loaded it if it was expired lol)
Handle a case for bots to avoid doing an HTTP request for them.
Add mips to Material to make sure it looks good on different scales.

Srlion added 5 commits

December 29, 2024 14:13


          Cleanup trailing whitespaces

0ecd544


          Always use PNG as file ext

06772c6


          Fix a bug where it never loads from cache

ac1a0fe


          Early return avatar_default if a bot

8262b2d


          Use "smooth mips" for avatar materials to improve texture quality

4f18453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet