Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User authentication configuration #5727

Closed
wants to merge 656 commits into from
Closed

User authentication configuration #5727

wants to merge 656 commits into from

Conversation

BurntimeX
Copy link
Member

A central location for the configuration should make it easier to disable certain unwanted functions in SSO plugins.

@BurntimeX BurntimeX requested a review from dtdesign December 13, 2023 13:43
dtdesign
dtdesign requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@dtdesign dtdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @since 6.1 to each doc block, otherwise LGTM.

Cyperghost and others added 28 commits February 2, 2024 12:01
@Cyperghost
Remove unused types
a6d5c1a 
Insert image class for media and attachments
@BurntimeX @dtdesign
Apply suggestions from code review
36f9aaa 
Co-authored-by: Alexander Ebert <[email protected]>
@Cyperghost
Add a check that variables_order has ENV active
279a1a9
@Cyperghost
Merge pull request #5791 from WoltLab/cli-worker-threads-env-info
e8b4339 
Add a check that `variables_order` has `ENV` active
@Cyperghost
Merge pull request #5789 from WoltLab/bugfix/notifcation-empty-recipient
0de8476 
Check if recipientIDs empty
@dtdesign
Fix the support for numeric phrase variants
d11cd7d
@BurntimeX
Make use of the objectIDs parameter
85b2d28
@BurntimeX
Change references in templates to the new page
36583b6
@BurntimeX
Add redirect to new rss feed page
a9da842
@BurntimeX
Deprecate old code
b5eb998
@BurntimeX
Add missing phpdoc
c049e54
@BurntimeX
Use new implementation for notification feed page
885219c
@BurntimeX
Deprecate old code
f922c09
@BurntimeX
Add cache for user ranks
fb68d74
@BurntimeX
Make use of the new cache
5133f2d
@BurntimeX
Remove obsolete code
39e3db6 
It's no longer necessary to joins the user_rank table.
@BurntimeX
Fix error in user search
2ef0c53 
The error is caused by an empty radiobutton.
```
preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
```
@Cyperghost
Fixes the error that the order of links and text was swapped in unfurl
1f4a900
@Cyperghost
Make HtmlUpcastProcessor final
9d7de79
@Cyperghost
Fix that wsm images can inside a link
6fafaf3
@Cyperghost
Change upcast, that the function replace the elements and not get a f…
a723834 
…ragment
@BurntimeX
Merge pull request #5790 from WoltLab/rss-feed
333f16f 
Add API for RSS feed generation
@Cyperghost
Replace element with correct img-element
361f3ac
@Cyperghost
Create simple image metacode upcast class
2a684c8
@Cyperghost
Make AttachmentRuntimeCache final
5759ccd
@Cyperghost
Insert some class docs
099374b
@dtdesign
Force backslashes for non imported namespaces
d9f6516
@BurntimeX
Merge pull request #5792 from WoltLab/user-rank-cache
e97ce10 
User rank cache builder
Cyperghost and others added 29 commits March 21, 2024 10:28
@Cyperghost
Add new function canModerateObjectto ICommentManager
57a5277
@Cyperghost
Allow the SessionHandler as $user parameter, too
ee8b210
@Cyperghost
Use new function canModerateObject to check if the user has permiss…
d6306bd 
…ion to this moderation queue item
@Cyperghost
Add further variables to the language variables
139058c
@BurntimeX
Fix status code
fb43724
@BurntimeX
Add exceptions for some actions
6c281f8 
These actions are required for registration or general tasks.
@BurntimeX
Apply "Force login" for users with pending activation
c6ac491
@BurntimeX
Merge pull request #5854 from WoltLab/force-login-middleware
e8f51db 
Move check for `FORCE_LOGIN` into a Middleware
@Cyperghost
Revert "Allow the SessionHandler as $user parameter, too"
f370c23 
This reverts commit ee8b210.
@Cyperghost
Add isAffectedUser function the comment `AbstractCommentResponseMod…
a75c6f9 
…erationQueueHandler`
@Cyperghost
Fix parent call
a35bcd4
@Cyperghost
Add $userID parameter to isAccessible in UserProfile
667b6f4
@Cyperghost
Add $user parameter to isAccessible function in Page
d238ca4
@Cyperghost
Added new function canViewObject to ICommentManager to check acce…
a80b5a3 
…ss to any object of comments.
@Cyperghost
Allow null value
069df38
@Cyperghost
Correct the check if user can access the profile
fa3027e
@Cyperghost
Add userID to $data array
a8497e0
@Cyperghost
Add new interface ICommentPermissionManager
4f9ce52
@Cyperghost
Implement the new interface ICommentPermissionManager in the commen…
248f7c9 
…t managers
@Cyperghost
Run php-cs-fixer
4d57ad2
@Cyperghost
Use runtime cache for article content
a415fd1
@Cyperghost
Update php doc for deprecation info
28c0f4f
@Cyperghost
Update code-style in UserProfileCommentManager
4d41fef
@Cyperghost
Add .class to file name
24d640d
@Cyperghost @dtdesign
Update wcfsetup/install/files/lib/system/comment/manager/ICommentPerm…
4585f1a 
…issionManager.class.php

Co-authored-by: Alexander Ebert <[email protected]>
@Cyperghost
Merge pull request #5852 from WoltLab/moderation-notification-report
e1d5b9e 
Moderation notification report
@BurntimeX
User authentication configuration
6dc6dae 
A central location for the configuration should make it easier to disable certain unwanted functions in SSO plugins.
@BurntimeX
Add since tag / fix license tag
b022d22
@BurntimeX
Merge branch 'user-auth-configuration' of https://github.com/WoltLab/WCF
728951a 
 into user-auth-configuration
@BurntimeX BurntimeX closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdesign dtdesign dtdesign requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BurntimeX @dtdesign @Cyperghost @IceQ1337