Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File processor image cropping #6047

Merged
merged 38 commits into from
Dec 23, 2024
Merged

File processor image cropping #6047

merged 38 commits into from
Dec 23, 2024

Conversation

Cyperghost
Copy link
Contributor

@Cyperghost Cyperghost commented Nov 6, 2024 •
edited
Loading

Lets you crop images in two ways:

Min Max

  • Allows the user to crop the image to a specified minimum and maximum size
  • Minimum and maximum must have the same aspect ratio

Exact

  • Alles sizes must have the same aspect ratio
  • If the image already corresponds to the correct dimensions, no dialog is displayed and the image is uploaded directly
  • The cropped image will be resized to the largest possible size

@Cyperghost Cyperghost requested a review from dtdesign November 6, 2024 09:25
@Cyperghost Cyperghost force-pushed the file-upload-image-crop branch from 9764802 to 5a38bab Compare November 6, 2024 09:41
@Cyperghost Cyperghost mentioned this pull request Nov 8, 2024
Merged
18 tasks
@Cyperghost Cyperghost marked this pull request as ready for review November 11, 2024 11:58
@Cyperghost
Merge remote-tracking branch 'origin/6.2' into file-upload-image-crop
b6691c4 
# Conflicts:
#	package-lock.json
#	package.json
#	wcfsetup/install/lang/en.xml
dtdesign
dtdesign reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@dtdesign dtdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far but the final verdict depends on the implementation of the cover photo so that we can validate the MinMax case with a real use case.

@Cyperghost Cyperghost mentioned this pull request Dec 2, 2024
Merged
2 tasks
@Cyperghost
Set the default selection to the maximum width
b140a08
@Cyperghost
Round the numbers
552d037
@Cyperghost
Run tsc
983dc4d
@Cyperghost
Calculate the size of the cropper selection in relation to the window…
9ad0476 
… size
@Cyperghost
Fixes the problem when the aspect ratio is less than 1, that the sele…
a9d93bf 
…ction has an incorrect resolution
@Cyperghost
Recalculate cropper height on window resize.
58dce4d 
Set height on container(parent) height
@Cyperghost
Center cropper-canvas.
243135e 
Fix, if the image on a side has a large dimension that a white area is displayed at the top and/or bottom
@Cyperghost
Add helper function to get the inner dimensions for an element
12a1c74
@Cyperghost
overwrites default values for min-width and min-height
3575389
@Cyperghost
Also note the maximum width that is available
1c6b805
@Cyperghost
Merge branch '6.2' into file-upload-image-crop
fc90f96 
# Conflicts:
#	.github/workflows/javascript.yml
#	wcfsetup/install/files/js/require.config.js
@Cyperghost
Resize the image to the maximum that the browser can display in the d…
50bed09 
…ialog.
@Cyperghost
Remove round
4c6e55c 
Limit to max width and height
@Cyperghost
Find the exact size for the image or use the minimum size for the image
c9726ad
@Cyperghost Cyperghost merged commit 4a4e638 into 6.2 Dec 23, 2024
8 checks passed
@Cyperghost Cyperghost deleted the file-upload-image-crop branch December 23, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdesign dtdesign dtdesign left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyperghost @dtdesign