Improve grid visualizer resize observation #68842
Draft
+17
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Enhancement
|
Size Change: -52 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow up to #68230 where it was noted that:
A resize observer can detect that change, but it has to be specified to observe the border-box. That’s because vertical padding in most cases will affect not the content-box but the border-box.
Why?
Primarily, to have the keep the grid visualizer in sync with changes to global styles like margin/border/padding. I’ve also tried some additional changes that aim to reduce resource usage by instantiating less objects and observing fewer elements.
How?
The core changes are these:
There are a few more things that didn’t have to be changed and I will add review comments for explanation/discussion.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
grid-visulizer-v-global-styles-padding-block-before.mp4
After
grid-visulizer-v-global-styles-padding-block-after.mp4