Add optional chain to sizes indexing of media details in edit-site

[grgar]

What?

This optional chaining is already present in 21 other lines in Gutenberg where sizes (in media_details) is indexed, but is missing on these two lines.

Why?

For some reason, media_details is an empty object for some of my attachments on my site, so this throws a TypeError. This change resolves this issue.

How?

?. is optional chaining to short circuit before the TypeError.

Testing Instructions

I don't actually know how some attachments don't have media_details on my site in the first place. I tried to reproduce on a playground with some hooks from the real site, e.g.

add_filter( 'intermediate_image_sizes', '__return_empty_array' );

1. Make attachment(s) which don't cause media_details to be set (see above).
2. Create a page and set one of these attachments as the featured image of the page.
3. Open /wp-admin/site-editor.php?postType=page to trigger the page thumbnails to be shown in the list, which triggers this code path and throws the TypeError without this change.

n/a from PR template

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: grgar <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @grgar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[Mamaduka]

Thanks, @grgar!

The patch works as expected ✅