Fixed: Empty Pattern Overlap in Pattern Title in Dataviews Table Layout #68997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8e7bfe1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13140253749
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Feb 3, 2025
|
Thanks for the Feedback. I didn't check in Different languages. I have test in English language only but i will test this in different languages. |
shail-mehta
force-pushed
the
fix/empty-pattern-overlap-in-dataviews-table-layout
branch
from
f9701da to
8a4c7c4
Compare
|
French Language:
German Language:
RTL :
|
|
I have tested in some different Languages & fixed Overlap Issue in RTL Language. |
t-hamano
reviewed
Feb 5, 2025
Comment on lines
49
to
51
| white-space: nowrap; | ||
| white-space: normal; |
There was a problem hiding this comment.
This cannot be changed because it would cause unintended changes in long pattern category titles.
white-space: nowrap (trunk)
white-space: normal (This PR)
There was a problem hiding this comment.
I will check another way without affect existing
shail-mehta
force-pushed
the
fix/empty-pattern-overlap-in-dataviews-table-layout
branch
from
8e7bfe1 to
3844b8a
Compare
|
I have reverted white-space CSS changes because issue will Resolved with There was caching issue in my local setup. (Attached Latest Screenshot for RTL)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing all patterns on Appearance > Editor > Patterns using the table layout, the text that explains that a pattern is empty overlaps the pattern name. This makes the text difficult to read.
What?
Closes #68937
Why?
Empty Pattern Overlap in Pattern Title in Dataviews Table Layout So its Hard to Read.
Testing Instructions
Screenshots or Screencast
Before Patch
After Patch