Fix: Site Editor should display a 404 message #69009
Open
+48
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new "notfound" route to the site editor routes
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
added
[Type] Bug
|
Size Change: +158 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d89b362. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13112860647
|
|
@jsnajdr, @youknowriad, can you look at this when you have time? I'm not very familiar with Routes API. |
|
The routing aspect look good to me. |
|
This solution doesn't add knowledge of "no route found" to the router library though but it doesn't bother me much. |
I wasn't able to figure out how to do it. I hope it doesn't cause any future problems. |
|
Should we improve the mobile layout too? With this PR, the menus are displayed even if there are no routes, but there is no text to indicate that there are no routes.
|
|
Below is a new screenshot of the sidebar on small screen widths, with a custom description.
|
|
I'm not sure I can give feedback on the design, but the text and layout seem good enough to me for now 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #67445
This PR displays a 404 Not Found message when a user visits a Site Editor screen that does not exist.
It adds a new route to the edit site package, based on the comments on
#67773
Why?
A 404 message was missing.
How?
This PR adds a new route called
notFoundRouteto the edit site package.It uses
*as the value for thepath, with the intention to catch, well, everything that isn't already on another existing route.The
sidebaruses the main navigation screen sidebar, so that it is easy for users to navigate away from the 404.The 'content' Is a translatable text: __( '404 (Not Found)' ).
Agreed, the message is nothing fancy, It could be a larger text and centered.
Testing Instructions
Activate a block theme.
Navigate back and forward around the existing screens to look for any regressions.
Try navigating to wp-admin/site-editor.php?p=%2Ftemplate-fdgfdgdfg. The 404 message should show.
Screenshots or screencast